-
-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added initial zhimi.humidifier.ca6 support #1885
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1885 +/- ##
==========================================
+ Coverage 81.41% 81.58% +0.16%
==========================================
Files 193 194 +1
Lines 18636 18857 +221
Branches 4045 4114 +69
==========================================
+ Hits 15173 15384 +211
- Misses 3180 3185 +5
- Partials 283 288 +5 ☔ View full report in Codecov by Sentry. |
Dear @rytilahti and @syssi , first of all, I have to say that I'm not a professional software developer for a long time. Thus please excuse me for my way of working with GitHub (branching, PR, etc.) In addition to this PR I have implemented initial support of But I can't make PR to home-assistant/core because of the
So, I don't know how to proceed. Maybe you can backport my changes and release Here are a few screenshots from HA: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply, but instead of creating a new file to maintain, it would be better to either use genericmiot
or adapt the airhumidifer_miot
as necessary.
I moved CA6 support to I also noticed that in order to support |
I added |
+1 |
1 similar comment
+1 |
Looks much better, thanks. I'm wondering, are these devices so different that they wouldn't fit in the same implementation class? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this can be revisited and polished if need to be, thanks @smmoroz! 👍
Adds support for zhimi.humidifier.ca6 and status container descriptors for airhumidifier_miot.
Closes #1884.