Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the mac address as property of the device info #260

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Provide the mac address as property of the device info #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions miio/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,12 @@ def hardware_version(self) -> Optional[str]:
return self.data["hw_ver"]
return None

def mac_address(self) -> Optional[str]:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better if this would also be a property like the rest of them?

"""MAC address if available."""
if self.data["mac"] is not None:
return self.data["mac"]
return None

@property
def raw(self):
"""Raw data as returned by the device."""
Expand Down