Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repr of the AirPurifierStatus fixed #265

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Repr of the AirPurifierStatus fixed #265

merged 2 commits into from
Mar 15, 2018

Conversation

sq5gvm
Copy link
Contributor

@sq5gvm sq5gvm commented Mar 14, 2018

…d4286529f636efc3244c5485d0893f511 (issue #264).

@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.242% when pulling a224e6b on sq5gvm:master into a10c771 on rytilahti:master.

@coveralls
Copy link

coveralls commented Mar 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 68.242% when pulling 2d481f0 on sq5gvm:master into a10c771 on rytilahti:master.

syssi
syssi requested changes Mar 15, 2018
View reviewed changes
Copy link
Collaborator

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only remove the % at the end of line 321 and 322. Don't remove the property use_time from repr.

@sq5gvm
Copy link
Contributor Author

sq5gvm commented Mar 15, 2018

Attribute use_time in line 322 is a duplicate, as it's already present in line 307. Do we really need both?
Sorry I forgot to mention it in commit message.

@syssi syssi changed the title Fixed TypeError in airpurifier.py module introduced in commit 65aeca5… Repr of the AirPurifierStatus fixed Mar 15, 2018
@syssi syssi merged commit 1fd013d into rytilahti:master Mar 15, 2018
@syssi
Copy link
Collaborator

syssi commented Mar 15, 2018

@sq5gvm Thanks! 73 de DO2KSM.

@syssi
Copy link
Collaborator

syssi commented Mar 15, 2018

Damn, you are right! :-) I missed your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syssi syssi syssi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sq5gvm @coveralls @syssi