Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Vacuum: Provide human readable fan speeds #468

Closed
wants to merge 1 commit into from
Closed

WIP: Vacuum: Provide human readable fan speeds #468

wants to merge 1 commit into from

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Jan 23, 2019

No description provided.

@syssi syssi mentioned this pull request Jan 23, 2019
Closed
9 tasks
@syssi syssi requested a review from rytilahti January 23, 2019 10:15
syssi
syssi commented Jan 23, 2019
View reviewed changes
miio/vacuum.py
)
def set_fan_speed(self, speed: int):
def set_fan_speed(self, speed: str):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to pass a Enum here. @rytilahti any suggestions?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 72.051% when pulling ca2126b on syssi:feature/vacuum-fan-speeds into f586c80 on rytilahti:master.

@poma
Copy link

poma commented Jan 23, 2019

The new vacuum still supports setting speed in percentage (0-100) like in the old one, and it can still return percentage values that will not fit any of predefined values. So methods that work with raw values are still needed.

@syssi
Copy link
Collaborator Author

syssi commented Jan 23, 2019

Thanks for the hint! I will update my proposal soon!

@syssi syssi changed the title Vacuum: Provide human readable fan speeds WIP: Vacuum: Provide human readable fan speeds Jan 23, 2019
bugficks added a commit to bugficks/python-miio that referenced this pull request Jun 25, 2019
@bugficks
My shot at 'Vacuum: Provide human readable fan speeds (rytilahti#468)'
e53d373
@bugficks bugficks mentioned this pull request Jun 25, 2019
Closed
@tribut
Copy link
Contributor

tribut commented Jul 29, 2019

Not sure if this is the correct place to report it, but given that #523 is closed -
for the Xiaowa E2, the official app sets the fan speeds as following:

Silent 50
Standard 68
Strong 79
Max 100

@tribut tribut mentioned this pull request Nov 8, 2019
Closed
@pplucky pplucky mentioned this pull request Feb 8, 2020
Closed
@rytilahti
Copy link
Owner

@syssi should we close this now that #643 is merged in?

@tribut tribut mentioned this pull request Jun 5, 2020
Merged
@rytilahti
Copy link
Owner

This is obsolete now.

@rytilahti rytilahti closed this Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti Awaiting requested review from rytilahti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@syssi @coveralls @poma @tribut @rytilahti