Fix miio-extract-tokens for devices without tokens #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `miio.extra_tokens.BackupDatabaseReader.decrypt_ztoken` method will raise a `TypeError` when a device in the SQLite database file has no token defined. This occurs for local (bluetooth) devices, such as the Mi Action Cam. This change will fix the `miio-extra-tokens` utility, so that it will work again, even if there are devices without tokens. See also issue rytilahti#467 for more informations.
|
Looks good, thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
miio.extra_tokens.BackupDatabaseReader.decrypt_ztokenmethod willraise a
TypeErrorwhen a device in the SQLite database file has notoken defined. This occurs for local (bluetooth) devices, such as the
Mi Action Cam.
This change will fix the
miio-extra-tokensutility, so that it willwork again, even if there are devices without tokens.
See also issue #467 for more informations.