Add tinymu smart toiletlid #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Xiaomi Tinymu toilet seat
key Error
houndci-bot
reviewed
Sep 2, 2019
miio/toiletlid.py
Outdated
| def status(self) -> ToiletlidStatus: | ||
| """Retrieve properties.""" | ||
| properties = AVAILABLE_PROPERTIES[self.model] | ||
| _props_per_request = 15 |
There was a problem hiding this comment.
local variable '_props_per_request' is assigned to but never used
rytilahti
requested changes
Sep 7, 2019
miio/toiletlid.py
Outdated
| return self.work | ||
|
|
||
| @property | ||
| def work(self) -> bool: |
There was a problem hiding this comment.
Is there a need for this property, considering there's already a more generic is_on?
miio/toiletlid.py
Outdated
| def status(self) -> ToiletlidStatus: | ||
| """Retrieve properties.""" | ||
| properties = AVAILABLE_PROPERTIES[self.model] | ||
| _props_per_request = 15 |
Device response error throws an exception
rytilahti
reviewed
Sep 10, 2019
…ising a warning and returning "Unknown" is more friendly.
rytilahti
approved these changes
Sep 10, 2019
|
Looks good to me now, thanks! 👍 One small thing, please add the full name of the device to README.md's list of supported devices. Also, if you have example outputs for those commands, please add them there for future reference (and to allow creating unit tests). @syssi, you are more knowledgeable on props based integrations, ok to merge? |
rytilahti
reviewed
Sep 11, 2019
|
Thanks! 🎉 edit: I fixed the conflicts caused by a recent merge, this is now good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select toiletlid status
set toiletlid ambient light
nozzle clean