Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device support of the Xiaomi Air Humidifier #66

Merged
merged 2 commits into from
Sep 8, 2017

Conversation

syssi
Copy link
Collaborator

@syssi syssi commented Sep 8, 2017

No description provided.

@@ -24,7 +24,7 @@
"zhimi-airpurifier-v3": AirPurifier,
"zhimi-airpurifier-v6": AirPurifier,
"chuangmi-ir-v2": ChuangmiIr,
# "zhimi-humidifier-v1": Humidifier,
"zhimi-humidifier-v1": AirHumidifier,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undefined name 'AirHumidifier'

@coveralls
Copy link

coveralls commented Sep 8, 2017

Coverage Status

Coverage increased (+1.0%) to 34.016% when pulling cf03ad8 on syssi:feature/humidifier into adfa737 on rytilahti:master.

@rytilahti
Copy link
Owner

Thanks, looks like there is quite a bit of shared features between the devices, maybe this can be refactored later on somehow..

@rytilahti rytilahti merged commit a4d85a1 into rytilahti:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants