support some more devices #689
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add device AqaraSwitchOneChannel (product QBKG11LM) and AqaraSwitchTwoChannels (product QBKG12LM). The new SensorHT (product WSDCGQ11LM) can get pressure. the Plug can get load_power. Have tested on my devices.
|
Looks good to me, I'm just wondering if this could break it for previous sensor models? Also, it would be great if you could add a simple example in the documentation/code how to access the sub-device data. |
|
I implemented this PR based on the new structure: #708 |
|
@rytilahti I think this PR can now be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add device AqaraSwitchOneChannel (product QBKG11LM) and AqaraSwitchTwoChannels (product QBKG12LM). The new SensorHT (product WSDCGQ11LM) can get pressure. the Plug can get load_power.
Have tested on my devices.