Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add next_schedule to vacuum timers #712

Merged
merged 6 commits into from
May 30, 2020
Merged

Add next_schedule to vacuum timers #712

merged 6 commits into from
May 30, 2020

Conversation

MarBra
Copy link
Contributor

@MarBra MarBra commented May 29, 2020

No description provided.

@coveralls
Copy link

coveralls commented May 29, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 73.379% when pulling 273dd80 on MarBra:master into 82f2b4d on rytilahti:master.

@MarBra MarBra marked this pull request as ready for review May 29, 2020 19:12
rytilahti
rytilahti reviewed May 29, 2020
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a couple of very minor things, otherwise this looks good to me.

miio/vacuum.py Outdated Show resolved Hide resolved
miio/vacuumcontainers.py Outdated Show resolved Hide resolved
miio/vacuumcontainers.py Show resolved Hide resolved
MarBra and others added 3 commits May 29, 2020 21:41
@MarBra
Move self.timezone() out of loop
7b4bc5a
@MarBra @rytilahti
Update miio/vacuumcontainers.py
6dc9f21 
Co-authored-by: Teemu R. <tpr@iki.fi>
@MarBra @rytilahti
Update miio/vacuumcontainers.py
273dd80 
Co-authored-by: Teemu R. <tpr@iki.fi>
@rytilahti rytilahti changed the title Add next_schedule to Timer Add next_schedule to vacuum timers May 30, 2020
@rytilahti rytilahti merged commit f9c396b into rytilahti:master May 30, 2020
@lpfann lpfann mentioned this pull request Jul 14, 2020
Closed
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@MarBra @rytilahti @xvlady
Add next_schedule to vacuum timers (rytilahti#712)
712b4b7 
* Add next_schedule to Timer

* Add poetry.lock

* Update poetry.lock

* Move self.timezone() out of loop

* Update miio/vacuumcontainers.py

Co-authored-by: Teemu R. <tpr@iki.fi>

* Update miio/vacuumcontainers.py

Co-authored-by: Teemu R. <tpr@iki.fi>

Co-authored-by: Teemu R. <tpr@iki.fi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarBra @coveralls @rytilahti