Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent icon sizes on hidpi screens #35

Open
calliecameron opened this issue Jul 22, 2016 · 7 comments
Open

Inconsistent icon sizes on hidpi screens #35

calliecameron opened this issue Jul 22, 2016 · 7 comments

Comments

@calliecameron
Copy link

Hi,

Using Emacs 24.5.1 on Linux Mint 18 with HiDPI scaling turned on, some icons are very small:

image

The text mode and autorevert icons are normal sized, but the python and terminal icons are small. I think this might have something to do with using icons from fonts vs. XPMs; I have FontAwesome, mfizz and IcoMoon installed on my system.

@mattfidler
Copy link
Collaborator

Yes. This is because of the difference between pixel icons vs fonts.

Is your emacs compiled with Imagemagick support? In theory, emacs should resize the images if you do...

@mattfidler
Copy link
Collaborator

Same size icons could also be supported if:

  • emacs has svg support
  • emacs allows resizing of svgs
  • mode-icons supports svgs.

Or,

  • mode-icons supports svg files by rescaling them in GIMP...

@calliecameron
Copy link
Author

Is your emacs compiled with Imagemagick support?

I think so - at least, imagemagick-types exists and returns a big list of file types. Are there any particular variables I would need to set to make image resizing work? My emacs can also open svgs, but I'm not sure if that's a default feature or something I had to enable at compile time.

mattfidler added a commit to mattfidler/mode-icons that referenced this issue Aug 5, 2016
@mattfidler
Copy link
Collaborator

It seems it is supported on your system. Perhaps you can add some amount to the height to have the images resized appropriately...? I have added an option mode-icons-line-height-adjust to allow manual adjustment...

@calliecameron
Copy link
Author

Finally had a chance to try this, but it doesn't seem to be working. The small icons are still the same size no matter what I set mode-icons-line-height-adjust to.

In case it was a conflict with something else in my configuration, I tried it with a blank .emacs, just installed the package and then did:

(setq mode-icons-line-height-adjust 20) ; or any other number
(mode-icons-mode)

Is that right?

@mattfidler
Copy link
Collaborator

In theory it should work, but obviously it doesn't. I'm not sure why. It may work in a standard buffer, but not in the mode line.

@To1ne
Copy link

To1ne commented Mar 2, 2017

Having decent support for HiDPI would be a really big plus.

How about creating @2x versions of the icons?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants