Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate return value #4

Merged
merged 1 commit into from
Apr 25, 2017
Merged

Propagate return value #4

merged 1 commit into from
Apr 25, 2017

Conversation

RGBboy
Copy link
Contributor

@RGBboy RGBboy commented Apr 25, 2017 •
edited
Loading

We have been using mocha-each and chai-as-promised and found a little issue. chai-as-promised allows you to return a promise from the function passed to it. Unfortunately mocha-each does not propagate this return value so tests unexpectedly pass. This PR adds propagating the return value.

Please let me know if there is any issue with this PR and I will fix it up.

@coveralls
Copy link

coveralls commented Apr 25, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a47fa54 on RGBboy:return-from-test into e9bfd29 on ryym:master.

ryym
ryym approved these changes Apr 25, 2017
View reviewed changes
Copy link
Owner

@ryym ryym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR!

@ryym ryym merged commit f9fb01a into ryym:master Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryym ryym ryym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RGBboy @coveralls @ryym