Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only exclude option #694

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Support only exclude option #694

merged 3 commits into from
Feb 15, 2023

Conversation

shima-zu
Copy link
Contributor

@shima-zu shima-zu commented Feb 15, 2023

Hi, @ryz310 👋
I have suggestion for rubocop_challenger.

I wanna support only_exclude option that applies --auto-gen-only-exclude when generate .rubocop_todo.yml.

e.g.

$ bundle exec rubocop_challenger go \
  --email=hoge@example.com \
  --name=fuga \
  --only_exclude

_rubocop_todo_yml

My team uses --auto-gen-only-exclude option in rubocop_todo, but PRs created rubocop_challenger don't use it. So, there are many diffs.

( Maybe you can support in this issue #618 ?? )

Could you consider it?
Please tell me if you have any suggestions or find mistakes.

@ryz310 ryz310 merged commit 6541147 into ryz310:master Feb 15, 2023
@ryz310
Copy link
Owner

ryz310 commented Feb 15, 2023

Hi, @shima-zu 👋

Thank you for your suggestion! LGTM ✅
I will release it after testing 🚀

@ryz310
Copy link
Owner

ryz310 commented Feb 15, 2023

@shima-zu
v2.11.0 released! 🚀
Thank you for your contribution! ✨

@shima-zu
Copy link
Contributor Author

@ryz310 Thank you for quick release! I try it 👍

@shima-zu shima-zu deleted the feature/support-only-exclude branch February 15, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants