Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset vpn + Add support for other OSes in GitHub actions #252

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

AdityaGarg8
Copy link
Contributor

It was broken in the latest release

@AdityaGarg8 AdityaGarg8 changed the title Fix reset vpn Fix reset vpn + Add support for other OSes in GitHub actions Dec 13, 2024
@AdityaGarg8
Copy link
Contributor Author

Currently, macOS github actions is very reliable

@rzc0d3r rzc0d3r merged commit 63b54f7 into rzc0d3r:main Dec 13, 2024
@AdityaGarg8
Copy link
Contributor Author

AdityaGarg8 commented Dec 13, 2024

You can also change your test.yml to use macOS. Just replace apt with brew, and runner os to macos-latest, as I have done in this PR.

@AdityaGarg8
Copy link
Contributor Author

Since both macos and linux use bash, everything else is the same.

@AdityaGarg8
Copy link
Contributor Author

Windows code is slow in this PR, but works. You need to change it to powershell, rn it is emulating bash. I don’t know much powershell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants