Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Domain Name for SharePoint Online - Override the default auth resolver #56

Closed
larnera opened this issue Sep 24, 2018 · 4 comments

Comments

@larnera
Copy link

larnera commented Sep 24, 2018

Hi. We use a custom domain name for SharePoint Online which means the auth resolver thinks the SharePoint environment we're using is on premise and not SP Online.

We can get around this by setting the below in AuthResolverFactory.js :

if (authOptions.isUserCredentialsOnpremise(siteUrl, options)) { return new OnlineUserCredentials_1.OnlineUserCredentials(siteUrl, options); }

I was wondering though, is this something you can add into the next release, maybe set a flag in the options which allows us to override the auto auth resolver?

Many thanks, Adam

@larnera larnera changed the title Custom Domain Name for SharePoint Online Custom Domain Name for SharePoint Online - Override the default auth resolver Sep 24, 2018
@s-KaiNet
Copy link
Owner

Hi,
good point. Strangely enough, that this bug was revealed only today. Looks like custom domains for Online is a fairly rare feature, isn't it?

I will release an update later this week.

@larnera
Copy link
Author

larnera commented Sep 24, 2018

Many thanks @s-KaiNet. Yep, it's pretty rare from what I can gather. I can't find much online about custom domains for SharePoint Online so maybe it's a new thing MS have enabled - we moved to O365 just last week.

Much appreciated. Cheers.

@s-KaiNet
Copy link
Owner

s-KaiNet commented Sep 26, 2018

Now you can explicitly add online: true to your credentials. In that case it resolves Online auth provider and works according to your needs.

I'm closing it for now, please reopen if there is still any issue.

@larnera
Copy link
Author

larnera commented Sep 27, 2018

This is brilliant! Thanks for doing this and making the change so quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants