Release 3.0

[s-panferov]

• Refactor
• Always fork a child process for speed
• Remove all custom resolution logic
• Support typescript 2.0.6 and the latest webpack@beta
• Align configuration options with ts-loader
• Test on typescript@next
• Test on Windows
• Receive feedback
• Update README
• Consider to port separate-process-checker to ts-loader, Joining forces with ts-loader? #266

Blockers:

• [3.0.0-beta.3] TypeError: Cannot read property 'forEach' of undefined #277
• ATL hangs on compiling #279
• 3.0.0-beta.3 doesn't work with typescript@next #282
• 'channel closed' on watch #287

[Ciantic]

I tested on windows, seems to work so far. I'll post here if I encounter something with my Windows setup.

[s-panferov]

@Ciantic thanks! I appreciate that.

[endel]

I just tried out v 3.0.0.beta.0, and I'm having this error:

Error: Cannot find module 'enhanced-resolve/lib/getInnerRequest'

Do you have any clue? Thanks!

[dsifford]

Just updated and it looks like ForkCheckerPlugin is now either broken, or deprecated.

Also I'm getting this error:

(node:18815) Warning: Possible EventEmitter memory leak detected. 11 exit listeners added. Use emitter.setMaxListeners() to increaselimit

Also: Even after it crashes, the process is still open. In other words, I have to press cmd-c just to get the process to exit.

[niieani]

It would be good to tackle this issue before 3.0: #129.

[cortopy]

beta2 works really good for me on Linux. In fact, it just solved an issue I've had with tslint output for a long time #273

[jefbarn]

beta.3 using typescript 2.1.1 just hangs after showing
[at-loader] Using typescript@2.1.1 from typescript and "tsconfig.json" from C:\projects\dayapp/tsconfig.json

[vascofernandes]

same problem as jefbarn but for TS 2.0.10

[s-panferov]

@vascofernandes do you have some example to reproduce?

[LennyThompson]

ATL 3.0.0-beta.3 is ignoring exclude configuration from webpack - using filter /.(spec|e2e).ts/ still compiles the spec files. You can test this with the angular2-webpack-starter by updating ATL to latest and removing the ForkCheckerPlugin reference... Reverting to 2.2.1 fixes the problem.

[niieani]

@LennyThompson I think you should ignore those files from within tsconfig.json. If you need, you can create a second tsconfig.json for the production build that doesn't include these spec files.

[LennyThompson]

Thanks for the response Bazyli, but does that mean the exclude configuration is ignored by ATL? and you need to control this through the tsconfig? Cheers Lenny

…

On Thu, Nov 24, 2016 at 9:16 PM, Bazyli Brzóska ***@***.***> wrote: @LennyThompson <https://github.com/LennyThompson> I think you should ignore those files from within tsconfig.json. If you need, you can create a second tsconfig.json for the production build that doesn't include these spec files. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#267 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALkaHyNR0p5z4KVPoh5FRZoAvUlALd4Yks5rBXIngaJpZM4KoJT_> .

[niieani]

Not sure what's the designed behavior for exclude configuration @LennyThompson, but ATL should follow the exclude list in tsconfig in any case.

[s-panferov]

@LennyThompson @niieani we have two different conceptions here:

1. "TypeScript program" — it's a scope of files which will be type-checked together. This scope is controlled by tsconfig.json.

2. Webpack Bundle — it's a scope of files which will be transpiled and included to a result bundle. This scope is controlled by webpack.config.js and its exclude rules.

[niieani]

@s-panferov yeah, this is how I understood it. Good points to add to the README, though ;)

[LennyThompson]

Thanks guys, I'll go back to version 3 then.

…

On 25 Nov 2016 19:37, "Bazyli Brzóska" ***@***.***> wrote: @s-panferov <https://github.com/s-panferov> yeah, this is how I understood it. Good points to add to the README, though ;) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#267 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ALkaH9vbgip1S2AanI7B_L0geeI9j-pnks5rBqxigaJpZM4KoJT_> .

[lhecker]

@s-panferov When using the webpack@2.1.0-beta.27 I'm constantly getting the following:

Typescript checker was exited with non-zero error code

Strangely if I use the webpack-dev-server@2.1.0-beta.12 it works fine though. (Using the same webpack.config.js!)

Any idea what could cause or how I should debug this?

[jefbarn]

Just wanted to let you know that 3.0 beta.9 is working again with my project. Thanks!

[pselden]

Has anyone seen this issue before (with beta.9):

This is in a very large project that uses 2 instances of ATL (and unfortunately I can't post the code). If no one has encountered an issue like this before I'll try to produce a minimal sample project that exhibits it.

Also -- the error repeats it self around 500 times.

More info: it doesn't always happen, sometimes it happens on first build, but mostly happens on rebuild during a watch.

[cortopy]

@pselden I've had that many times. It means lodash definitions are included more than once in your parsing. But I wouldn't say it has to do with v3 per se

[pselden]

#267 (comment) -- thanks, I just never saw it before until I updated to 3.x beta.

How would I go about fixing that then -- making sure there's only one lodash in my node_modules? One of the reasons I thought it might be an issue with v3 was that it only happens during a rebuild.

[cortopy]

Whenever it's happened to me, there was always a lot of trial and error. It used to happen a lot with my npm-linked modules, but new versions of TS have fixed that. Try with different options in tsconfig too (exclude the right folders, include only what's needed, etc.)

[pselden]

Now with ATL .17 beta I'm seeing a lot of "unknown error"

{ seq: 348, success: true, payload: null } // logged out res
Unknown message:  null

And then the build fails -- while in previous versions it would succeed. This does not happen when running in watch mode.

Any ideas where to look?

Note: "tsc" works correctly.

Another edit: I think it is similar to this other issue I see: #323 -- although I am using multiple instances of at-loader by using the 'instance' property (instead of multiple configs)