This repository was archived by the owner on Dec 1, 2019. It is now read-only.
[WIP] fix for concurrent webpack config "channel closed" error #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspecza
force-pushed
the
concurrent-webpack-fix
branch
from
d49c5f4 to
4bb3ba5
Compare
When exporting an array of configs from webpack.config.js, atl crashes. The error message is "channel closed", indicating that a forked child process is dying too soon. This commit changes the Checker class such that it's kill method sends a SIGTERM to the child process rather than a SIGKILL. The child process intercepts this signal and ignores it to ensure it is kept alive. Closes s-panferov#287
zspecza
force-pushed
the
concurrent-webpack-fix
branch
from
4bb3ba5 to
1692049
Compare
|
@declandewet thanks. I think that I've found a little bit better way to fix this in #297 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really know nothing about these different signals as I'm more of a web dev, so right now these changes are a bit of a hack - but it does prevent the "channel closed" error in #287.
I understand that leaving a forked process like this long running is a bit of a bad practice though, so I'm happy to receive any input on how to improve this :)
/cc @s-panferov does this by any chance indicate a path to a proper fix in your mind?