Improve dbDataType method for RJDBC connections #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbDataType used to return "VARCHAR(255)" for all text columns. Updated so that it returns "VARCHAR(<max nchar>)" for text columns.
s-u
force-pushed
the
master
branch
5 times, most recently
from
30654b9
to
7675ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dbDataType used to return "VARCHAR(255)" for all text columns.
Updated so that it returns "VARCHAR(
n)" for text columns, wherenis the maximum value ofnchar()for that column.This used to be the default behaviour for DBI, and it seems like sensible default behaviour for RJDBC.
See this link for a discussion around why it was changed to "TEXT" in DBI. I disagree with their logic, but you may find it more compelling.