Version 1.0.6 broke testing on Windows and macOS

[ocefpaf]

Our setup in in ioos/erddapy@9232d71 works with version 1.0.5 but not 1.0.6. See ioos/erddapy#193 where we had to pin the to previous version version to make it work.

Note that, by using activate-conda: true we could get 1.0.6 to work on Linux only. However, my understanding is that we don't need to activate the base env b/c we are activating the TEST env later.

Happy to provide any with further details if needed. Also, thanks for the awesome GHA! Very useful!!

[s-weigand]

Thanks for the report.
It looks like that with v1.0.6 on Linux for some reason /usr/bin is too early in the PATH and thus the system pip is used which requires sudo rights and thus fails to install your package.

• v1.0.5

  PATH: /usr/share/miniconda/bin:/usr/share/miniconda/envs/TEST/bin:/usr/share/miniconda/condabin:/usr/bin:/usr/share/miniconda/bin:/usr/share/miniconda:/home/linuxbrew/.linuxbrew/bin:
  

• v1.0.6

  PATH: /usr/share/miniconda/bin:/usr/bin:/usr/share/miniconda/envs/TEST/bin:/usr/share/miniconda/condabin:/usr/share/miniconda:/home/linuxbrew/.linuxbrew/bin
  

I will add a test with bash -l {0} and try to come up with a fix asap.

[s-weigand]

@all-contributors please add @ocefpaf for bug

[allcontributors]

@s-weigand

I've put up a pull request to add @ocefpaf! 🎉

[s-weigand]

Ok it looks like adding the env vars from the activation script (conda shell.<shell_name> activate <env_name>) broke the usage of source activate <env_name>.

@ocefpaf Would you be so kind and confirm that using s-weigand/setup-conda@fix-env-activation resolves your problem? 🤞

[s-weigand]

@ocefpaf Sorry the fix-env-activation branch didn't contain the transpiled code in dist/index.js that is why that run failed.
Could you try s-weigand/setup-conda@fix-env-activation-dist?

[ocefpaf]

Could you try s-weigand/setup-conda@fix-env-activation-dist?

Ah! I though it was copy-n-pasta from my side 😄

Done and it worked!

[s-weigand]

The problem with automating everything, is that you can easily forget something when it isn't the used workflow 😅

dist/index.js is bundled code used by the action, but not to have bundle conflicts it is in the .gitignore.
Since the CI first bundels the code and the tests use the bundle artifact from the previous job, I forgot that you can't use the branch directly to test it 😅

That is why I had to put a branch with the dist on top of the fix branch.