Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👌 Improve error handling when CONDA environ variable isn't set #434

Merged
merged 6 commits into from
May 17, 2024
Merged

👌 Improve error handling when CONDA environ variable isn't set #434

merged 6 commits into from
May 17, 2024

Conversation

s-weigand
Copy link
Owner

This action uses the preinstalled miniconda and determines its installation base path reading the CONDA environ variable.
Up until macOS-12 this worked for all runner images, however macOS-13 and macOS-14 (current macos-latest) do not install miniconda and workflows fail with:

Error: The "path" argument must be of type string. Received undefined

See #432

With this change, the error will be:

Error: Could not determine conda base path, it seams conda is not installed.

On any system without the CONDA environ variable set.
And for macos runner images > 12:

 Error: Could not determine conda base path, it seams conda is not installed.
  MacOS images newer than "macos-12" (i.e. "macOS-latest") are known to be incompatible with this action due to a missing miniconda installation.
  See: https://github.com/s-weigand/setup-conda/issues/432

s-weigand added 6 commits May 17, 2024 14:05
@s-weigand
🧹 Fix typo
c701d81
@s-weigand
👌 Raise error if CONDA env var isn't set
af97047 
👌 Reference issue in error for macOs > 12
@s-weigand
🚇🩹 Use macOS-12 instead of macOS-latest in CI
54b7642
@s-weigand
🚇🩹 Fix failing integration test for pypy2.7
04f4334 
The problem was that pip 9 (latest available pip for pypy2.7) uses outdated SSL certs resulting in the following error:
Collecting pytest
  Could not fetch URL https://pypi.python.org/simple/pytest/: There was a problem confirming the ssl certificate: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed - skipping
  Could not find a version that satisfies the requirement pytest (from versions: )
No matching distribution found for pytest
@s-weigand
🧪 Add unit tests for handling of missing CONDA env var
e66608a
@s-weigand
📚 Add disclaimer about not working with macOS > 12
ee2c7f3
@s-weigand s-weigand merged commit 74fc5b1 into main May 17, 2024
58 checks passed
@s-weigand s-weigand deleted the macos-gt-12-not-supported branch May 17, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-weigand