Add support for minDecimalScale #752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In many currency-related use cases, a minimal decimal precision of 2 digits is common. This way, large numbers get displayed with two padded zeroes (i.e. $1,000,000.00) while small numbers support added precision of up-to n digits ($0.89765412 if n=8) - This functionality is not currently possible with this library due to fixedDecimalScale enforcing EXACTLY n digits of precision, while decimalScale provides a MAXIMUM number of digits - In a future release (breaking change) we can probably remove `fixedDecimalScale` and use only `minDecimalScale` and `decimalScale` to clamp the bounds of precision and satisfy every use case
|
@RayzorFlash Thanks for the PR. And then we can mark decimal scale and fixedDecimalScale deprecated which we can remove on next major release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
In many currency-related use cases, a minimal decimal precision of 2 digits is common. This way, large numbers get displayed with two padded zeroes (i.e. $1,000,000.00) while small numbers support added precision of up-to n digits ($0.89765412 if n=8)
This functionality is not currently possible with this library due to fixedDecimalScale enforcing EXACTLY n digits of precision, while decimalScale provides only a MAXIMUM number of digits when used on its own
In a future release (since it would be a breaking change) we can probably remove
fixedDecimalScaleand use onlyminDecimalScaleanddecimalScaleto clamp the bounds of precision and satisfy every use caseExample usage (If applicable)
Please check which browsers were used for testing