fix focus wrong field #828
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-yadav
reviewed
May 18, 2024
| if (formattedValue !== lastUpdatedValue.current.formattedValue && input) { | ||
| const activeElement = document.activeElement; | ||
|
|
||
| if (input === activeElement && formattedValue !== lastUpdatedValue.current.formattedValue && input) { |
There was a problem hiding this comment.
Humm, @kasperdun can you share an example where this is breaking? Basically focusedElm.current is set only when that input is focused. As we set the focusedElm.current to undefined when a blur is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the issue/change
When I use react-hook-form with react-number-format
And I'm trying to implement a dynamic calculated field
I have one field that depends on a second field
When I type something in the second field, the cursor jumps from my field in which I write to the field in which I dynamically change the value
I fixed this by checking the currently active element with a focusedElm element to only do setPatchedCaretPosition on the field I'm interacting with
Please check which browsers were used for testing