feat: add target_dir to action options #82

jdcmarques · 2022-11-08T20:04:41Z

Context

Added TARGET_DIR option to allow to specify where we want the files to be copied to
- By default, it will only clean out the TARGET_DIR

requires #81
implements #70

marquesj2-ppb · 2022-11-11T09:18:02Z

Hey @s0, can you take a look at this PR?

s0

Awesome work, thanks so much! I've rebased it ontop of the other PRs I've now merged and your other work.

There may be one bug when deleting files, I'm going to create a unit test that checks this, and then address it, just to get this in :)

action/src/index.ts

README.md

jdcmarques force-pushed the feat/add-target-dir-options branch from 52fade4 to 2829101 Compare November 8, 2022 20:08

This was referenced Nov 8, 2022

feat: replace copy with node implementation #83

Merged

Allow for non-root target directory #70

Closed

s0 force-pushed the feat/add-target-dir-options branch from 2829101 to 48f9764 Compare November 17, 2022 22:33

feat: add target_dir to options

55e55bb

s0 force-pushed the feat/add-target-dir-options branch from 48f9764 to 55e55bb Compare November 17, 2022 22:48

s0 reviewed Nov 17, 2022

View reviewed changes

action/src/index.ts Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

s0 added 2 commits November 17, 2022 22:59

Add test that shows neste files aren't deleted with TARGET_DIR

f42367b

fix: recursively delete files in TARGET_DIR

ac9c405

s0 force-pushed the feat/add-target-dir-options branch from 6b28561 to ac9c405 Compare November 17, 2022 23:01

s0 enabled auto-merge November 17, 2022 23:02

chore: run lint:fix and build

65d1af0

s0 merged commit aa7ffa5 into s0:develop Nov 17, 2022