Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CBasePlayer::HasTimePassedSinceDeath() for m_fDeadTime #648

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

wopox1337
Copy link
Collaborator

No description provided.

@wopox1337 wopox1337 requested a review from s1lentq June 20, 2021 11:54
@wopox1337 wopox1337 self-assigned this Jun 20, 2021
@wopox1337 wopox1337 changed the title Implement CBasePlayer::HasTimePassedSinceDied() for m_fDeadTime Implement CBasePlayer::HasTimePassedSinceDied() for m_fDeadTime Jun 20, 2021
@wopox1337 wopox1337 changed the title Implement CBasePlayer::HasTimePassedSinceDied() for m_fDeadTime Implement CBasePlayer::HasTimePassedSinceDeath() for m_fDeadTime Jun 20, 2021
@wopox1337 wopox1337 merged commit 1ac96b8 into s1lentq:master Jun 21, 2021
@wopox1337 wopox1337 deleted the refactor-m_fDeadTime branch June 21, 2021 09:01
@StevenKal
Copy link
Contributor

Maybe a CVar or a hook for this could have been welcomed, to easily decide our own "observing duration".

@wopox1337
Copy link
Collaborator Author

Maybe a CVar or a hook for this could have been welcomed, to easily decide our own "observing duration".

If you need this functionality, I will be happy to accept your edits.

@StevenKal
Copy link
Contributor

Well, I have explained before some reasons why I can not post PRs in GitHub (Win XP bugged with GitHub; do not want to submit unless I can compile & test myself; which guarantee do I have to see my PR accepted & pushed soon?; etc.), but I can apparently see you recently got some "rights" to this official repository, and unlike someone else (grrrrr...), you seem to answer more (yiiiiihaaaa!!!), so I keep in mind that you said and if in case I at least update my OS to try compiling ReGameDLL_CS for testing, I will not forget to try submitting PRs I have in mind, I guess with you this will be quickly merged... Despite I still see a lot of PRs which should be merged...

But for now I prefer just suggesting possible fixes/changes (even if minor), because this is not me "behind", and some people like you are get use to do that & can do it very quickly "on the fly" if you have time for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants