Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix m_flAccuracy calculation #677

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Fix m_flAccuracy calculation #677

merged 2 commits into from
Sep 13, 2021

Conversation

wopox1337
Copy link
Collaborator

@wopox1337 wopox1337 commented Sep 11, 2021

Fixes and improves smooth spread transitions when shooting automatic weapons.
🤌

@wopox1337
Copy link
Collaborator Author

@StevenKal What do you think about this PR 🧐?

@hajimura
Copy link
Contributor

shedevr

@TibyXD
Copy link

TibyXD commented Sep 11, 2021

Related to Fix Accuracy plugin by MPNumB?

@StevenKal
Copy link
Contributor

Haha cute wopox, sounds like you want to keep me reactive or have fun with me! Hehehehehe!
And you, what do you think about my module ReAPI?!!! Hihihi!

I only see the usage of some #define rather than hardcoded numbers, well, just for the sake of "making the things clean" (readability...), there are PRs much more interesting than that! Come on I know you can submit more interesting! Hihihi!

@wopox1337
Copy link
Collaborator Author

wopox1337 commented Sep 11, 2021

what do you think about my module ReAPI?

Do it if you like it. 🤨

Come on I know you can submit more interesting! Hihihi!

From that moment on, my interest was gone. Thanks for the great review. 👍

just for the sake of "making the things clean" (readability...)

Absolutely not.

P.S: https://godbolt.org/z/7f98eejYf (№2)
telegram-cloud-photo-size-2-5325877679355966534-y

Come on, I know you can be more considerate and serious.

@hajimura
Copy link
Contributor

hajimura commented Sep 11, 2021

I only see the usage of some #define rather than hardcoded numbers, well, just for the sake of "making the things clean" (readability...), there are PRs much more interesting than that!

The PR fixes wrong m_flAccuracy calculation of weapons. Due this time there was a math data loss that was fixed by this code

@StevenKal
Copy link
Contributor

StevenKal commented Sep 11, 2021

"Come on, I know you can be more considerate and serious."

Show the good example in first!

So, this sucks to return a correct float? Well, I do not recall about that. But I usually always try to use same types of numbers in my codes so, I never get such issues.
I use my calculator & I get 0.04 so C++ compiler is dumb!

I guess you just wanted to know if I was aware about that crap, haha! No, I was not! Then what?
But if you want me to "thank you" for teaching me that issue/bug, well let's be nice & send a "thank you" to you!
So now you can bang on your chest like a gorilla! Huga! Huga!

@wopox1337 wopox1337 merged commit 667242f into s1lentq:master Sep 13, 2021
@fred0r
Copy link

fred0r commented Oct 6, 2021

I guess you just wanted to know if I was aware about that crap, haha! No, I was not! Then what? But if you want me to "thank you" for teaching me that issue/bug, well let's be nice & send a "thank you" to you! So now you can bang on your chest like a gorilla! Huga! Huga!

absolutely not my business, but you've a interesting way to thank for a free advice.

@wopox1337
thank you for this fix - it feels so good :)

@afwn90cj93201nixr2e1re
Copy link
Contributor

afwn90cj93201nixr2e1re commented Oct 7, 2021

Вообще... Просто к слову, зря, в кс много таких моментов где зачем-то использовали именно int'ы, когда меняешь, меняется сильно, но да ладно.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants