Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the order of setting pev->body for the correct value in SetBo… #893

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Changed the order of setting pev->body for the correct value in SetBo… #893

merged 1 commit into from
Nov 26, 2023

Conversation

Javekson
Copy link
Contributor

…mbIcon()

@dystopm
Copy link
Contributor

dystopm commented Nov 16, 2023

Also check C4::PrimaryAttack on wpn_c4.cpp

@Javekson
Copy link
Contributor Author

Also check C4::PrimaryAttack on wpn_c4.cpp

Could you provide more details on what's wrong with C4::PrimaryAttack in wpn_c4.cpp? It seems that pev->body is set there before SetBombIcon, which is the desired behavior, isn't it?

@dystopm
Copy link
Contributor

dystopm commented Nov 19, 2023

Also check C4::PrimaryAttack on wpn_c4.cpp

Could you provide more details on what's wrong with C4::PrimaryAttack in wpn_c4.cpp? It seems that pev->body is set there before SetBombIcon, which is the desired behavior, isn't it?

You're right! Mistake by watching my sources instead of this PR

@s1lentq s1lentq merged commit b10489f into s1lentq:master Nov 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Javekson @dystopm @s1lentq