Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add aspectj for new flows #47

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from

Conversation

abenaru-zz
Copy link

@abenaru-zz abenaru-zz commented Oct 21, 2020

Pull Request Merge Checklist

Task backlog identifier related to this PR: 541


As a DEVELOPER, I confirm that this PR doesn't contain:

  • Code lines with syntax errors
  • Methods and variables names that aren't clear or doesn't mean anything
  • Code that is out of the standard (Example: PEP-8 for Python code)
  • Files with imports errors or without any utility
  • TODOs left behind
  • Tests that are being skipped
  • Methods placed on incorrect files or folders (Example: methods that are local, but should be placed on /utils)
  • Functions, methods or API responses that are publicly returning sensitive information

As a DEVELOPER, I confirm that I:

  • Followed the Simbiose's standard for branch and commit naming
  • Concluded the task and achieved the goals according to the task planning I defined before starting to code
  • Added all necessary database changes to the SQL Migrations
  • Created tests for every new flow and method on this Pull Request
  • Added the necessary DEBUG logs
  • Checked my code using the Simbiose's Corner Cases Guide
  • Merged the develop branch to this PR/branch before sending the PR for review
  • Solved all possible merge conflicts before sending the PR for review
  • Corrected all the problems and code smells identified by the quality tools
  • Manually executed the necessary tests locally to make sure my changes didn't break anything
  • All unitary and integration tests ran by the CI system are passing
  • Check the performance of my changes or additions and they didn't make the system slower (I profiled the code)
  • Updated the necessary documentation (Example: OpenAPI, Docstrings, Metadata Database Modeling)
  • Made the self-review of the code before sending the PR for review
  • Sent this PR for a peer-review
  • Made all the corrections appointed during the peer-review
  • Confirmed that this PR merge will not cause other systems or dependencies to stop working (Example: ShannonDB Python Client and ShannonDB)
  • Checked all GitHub Actions related to this PR that can block my merge

As the TEAM MANAGER, I confirm that I:

  • Checked that the code was developed following the best practices for the language, with the best possible readability and using the less possible quantity of code lines and complexity.
  • Checked if the Pull Request and commit messages follow the Simbiose’s defined standard
  • Checked if there is no possible merge conflicts before reviewing the PR
  • Checked if the purpose of the task was reached with this PR
  • Checked that the code was developed following the best practices for the language, with the best possible readability and using the less possible quantity of code lines and complexity.
  • Checked if all related PRs were created when other components were affected by this task (e.g. database changes on SQL Migrations)
  • Checked that were created unit, integration and chaos tests for every new flow and method on this Pull Request
  • Checked that no sensible information (e.g. users security data, internal security data, etc) was exposed by this PR
  • Checked that code coverage for this PR is higher than 80%.
  • Checked that there are no problems and code smells identified by the quality and security tools
  • Checked that all files were created on the proper folders according to the Simbiose’s defined standard
  • Checked that all classes, methods and variables on this PR follow the Simbiose’s pattern for this programming language
  • Checked that all unitary and integration tests ran by the CI system are passing
  • Checked that there are no performance issues created by these changes or additions
  • Checked that all documentation is up to date according to this change (Example: OpenAPI, Docstrings, Metadata Database Modeling)
  • Checked that this PR merge will not cause other systems or dependencies to stop working (Example: ShannonDB Python Client and ShannonDB)
  • Checked all GitHub Actions related to this PR that can block the merge

As the QUALITY RESPONSIBLE, I confirm that I:

  • Checked if the Pull Request and commit messages follow the Simbiose’s defined standard
  • Checked if there is no possible merge conflicts before reviewing the PR
  • Checked that were created unit, integration and chaos tests for every new flow and method on this Pull Request
  • Checked that no sensible information (e.g. users security data, internal security data, etc) was exposed by this PR
  • Checked that code coverage for this PR is higher than 80%.
  • Checked that there are no problems and code smells identified by the quality and security tools
  • Checked that all files were created on the proper folders according to the Simbiose’s defined standard
  • Checked that all classes, methods and variables on this PR follow the Simbiose’s code standard for this programming language
  • Checked that all unitary and integration tests ran by the CI system are passing
  • Checked that there are no performance issues created by these changes or additions
  • Checked that all documentation is up to date according to this change (Example: OpenAPI, Docstrings, Metadata Database Modeling)
  • Checked that this PR merge will not cause other systems or dependencies to stop working (Example: ShannonDB Python Client and ShannonDB)
  • Checked all GitHub Actions related to this PR that can block the merge

Important links:

  1. Simbiose Quality Guidelines
  2. Metadata Database Modeling
  3. Simbiose's Corner Cases Guide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant