-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DS-172] Implement GET_JSON_OBJECT Hive function #9
base: master
Are you sure you want to change the base?
Conversation
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format?
or
See also: |
1f085f8
to
88c6577
Compare
@@ -18,6 +18,8 @@ | |||
#include "gandiva/gdv_function_stubs.h" | |||
|
|||
#include <utf8proc.h> | |||
#include <jsoncons/json.hpp> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't know if it is okay to use hpp references in Gandiva files.
Normally, I see cases in Gandiva where a wrapper .h file is created to avoid having these .hpp references (something related to compatibility problems while using llvm).
You may take a look at the decimal_xlarge.cc file which is a wrapper to use the boost .hpp file to handle some decimal operations
d5df84b
to
f08fb00
Compare
No description provided.