Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DS-172] Implement GET_JSON_OBJECT Hive function #9

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

augustoasilva
Copy link

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 6, 2021

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW

Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@augustoasilva augustoasilva force-pushed the feature/add-get-json-object-function branch from 1f085f8 to 88c6577 Compare July 7, 2021 01:04
@augustoasilva augustoasilva self-assigned this Jul 8, 2021
@@ -18,6 +18,8 @@
#include "gandiva/gdv_function_stubs.h"

#include <utf8proc.h>
#include <jsoncons/json.hpp>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if it is okay to use hpp references in Gandiva files.
Normally, I see cases in Gandiva where a wrapper .h file is created to avoid having these .hpp references (something related to compatibility problems while using llvm).

You may take a look at the decimal_xlarge.cc file which is a wrapper to use the boost .hpp file to handle some decimal operations

@augustoasilva augustoasilva force-pushed the feature/add-get-json-object-function branch from d5df84b to f08fb00 Compare September 13, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants