Skip to content

Commit

Permalink
update the pull request template (ethereum#306)
Browse files Browse the repository at this point in the history
  • Loading branch information
wjrjerome authored Aug 7, 2023
1 parent ef5d064 commit 1f0599a
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,34 @@ You description should at least include below key points:
## Types of changes

What types of changes does your code introduce to XDC network?
_Put an `x` in the boxes that apply_
_Put an `` in the boxes that apply_

- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Regular KTLO or any of the maintaince work. e.g code style
- [ ] Other (If none of the above is relevant, please specify reasons below)


## Impacted Components

Which part of the codebase this PR will touch base on,
_Put an `x` in the boxes that apply_
_Put an `` in the boxes that apply_

- [ ] Consensus
- [ ] Geth
- [ ] Network
- [ ] Smart Contract
- [ ] EVM
- [ ] Account
- [ ] Not sure
- [ ] External components
- [ ] Not sure (Please specify below)

## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
_Put an `` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._

- [ ] This PR have sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
- [ ] This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
- [ ] Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
- [ ] Tested the backwards compatibility.
- [ ] Tested with XDC nodes running this version co-exist with those running the previous version.
Expand Down

0 comments on commit 1f0599a

Please sign in to comment.