Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GPG "server" configuration for passphrase #223

Open
chrisvest opened this issue Jul 12, 2022 · 2 comments
Open

Support GPG "server" configuration for passphrase #223

chrisvest opened this issue Jul 12, 2022 · 2 comments
Labels
enhancement New feature or request. to grab Ready to do and to grab by those willing.

Comments

@chrisvest
Copy link

Is your feature request related to a problem? Please describe.
The maven-gpg-plugin can take the private key passphrase from a server configuration in settings.xml.
See: https://maven.apache.org/plugins/maven-gpg-plugin/usage.html#Configure_passphrase_in_settings.xml

Validation currently prevents the given examples from working, first saying that either username or configuration must be provided.
Then, when configuration is provided, the error is that username and password must be provided.
If username is provided then password must also be provided (according to settings.xml docs), but if password is provided then passphrase will supposedly be ignored.

Describe the solution you'd like
Make the validation allow servers that only have id and passphrase.

Describe alternatives you've considered
The alternative is to specify the GPG key passphrase on the command line, and rely on GitHub to filter secret data from the build logs.

@slawekjaranowski slawekjaranowski added enhancement New feature or request. to grab Ready to do and to grab by those willing. labels Jul 12, 2022
@slawekjaranowski
Copy link
Member

PR are welcome

@danielflower
Copy link

Workaround: give an empty configuration.

            {
              "id": "gpg.passphrase",
              "passphrase": "${{ secrets.OSSRH_GPG_SECRET_KEY_PASSWORD }}",
              "configuration": {}
            }

Ardesco added a commit to jmeter-maven-plugin/jmeter-maven-plugin that referenced this issue Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. to grab Ready to do and to grab by those willing.
Development

No branches or pull requests

3 participants