Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapshot-only keys for AO Jenkins continuous integration #448

Closed
wants to merge 1 commit into from

Conversation

ao-apps
Copy link
Contributor

@ao-apps ao-apps commented Dec 6, 2021

This requires the latest pgpverify-maven-plugin >= 1.15.1-SNAPSHOT

If you accept s4u/pgpverify-maven-plugin#347 first, we can bump this requirement to 1.16.0-SNAPSHOT before merging this PR.

@ao-apps ao-apps force-pushed the master branch 4 times, most recently from 3766681 to db1c26e Compare December 6, 2021 01:39
@ao-apps ao-apps marked this pull request as draft December 6, 2021 03:27
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 03:58
@ao-apps ao-apps marked this pull request as draft December 6, 2021 04:13
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 04:27
@ao-apps ao-apps marked this pull request as draft December 6, 2021 05:09
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 05:29
@ao-apps ao-apps marked this pull request as draft December 6, 2021 05:32
This requires the latest pgpverify-maven-plugin >= 1.15.1-SNAPSHOT
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 05:34
@ao-apps
Copy link
Contributor Author

ao-apps commented Dec 6, 2021

We do not expect any more changes. This PR should be OK now.

Thank you,
Dan

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ao-apps ao-apps marked this pull request as draft December 7, 2021 06:26
@ao-apps
Copy link
Contributor Author

ao-apps commented Dec 7, 2021

We've set this back to draft. It is worth discussing if snapshot-only keys even belong here. We have our own pgp-keys-map project where we can maintain snapshot-only keys.

@ao-apps
Copy link
Contributor Author

ao-apps commented Dec 15, 2021

We have decided to keep snapshot-only keys in our https://github.com/ao-apps/pgp-keys-map

@ao-apps ao-apps closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant