Merge pull request #267 from s4u/deprecate-failNoSignature

Deprecate failNoSignature option

src/it/noSigFail/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('[ERROR] No signature for junit:junit:jar:3.8')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[ERROR] Unsigned artifact is listed with key in keys map: junit:junit:jar:3.8')
+assert buildLog.contains('[ERROR] Unsigned artifact is listed with key in keys map: junit:junit:pom:3.8')
+
+assert buildLog.contains('[INFO] BUILD FAILURE')

src/it/providedProcess/pom-test.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-  ~ Copyright 2015 Slawomir Jaranowski
+  ~ Copyright 2015-2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -45,7 +45,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifyProvidedDependencies>true</verifyProvidedDependencies>
                 </configuration>
                 <executions>

src/it/providedProcess/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('[ERROR] No signature for junit:junit:jar:3.8')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[WARNING] No signature for junit:junit:jar:3.8')
+assert buildLog.contains('[WARNING] No signature for junit:junit:pom:3.8')
+
+assert buildLog.contains('[INFO] BUILD SUCCESS')

src/it/providedSkip/pom-test.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-  ~ Copyright 2015 Slawomir Jaranowski
+  ~ Copyright 2015-2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -45,7 +45,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifyProvidedDependencies>false</verifyProvidedDependencies>
                 </configuration>
                 <executions>

src/it/reactorProcessBundle/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('ERROR] No signature for test:project-bundle:jar:0.0.1')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[WARNING] No signature for test:project-bundle:jar:0.0.1')
+assert buildLog.contains('[WARNING] No signature for test:project-bundle:pom:0.0.1')
+
+assert buildLog.contains('[INFO] BUILD SUCCESS')

src/it/reactorProcessBundle/project-verifier/pom-test.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
   ~ Copyright 2018 Wren Security
+  ~ Copyright 2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -43,7 +44,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifyReactorDependencies>true</verifyReactorDependencies>
                 </configuration>
                 <executions>

src/it/reactorProcessJar/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('[ERROR] No signature for test:project-jar:jar:0.0.1')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[WARNING] No signature for test:project-jar:jar:0.0.1')
+assert buildLog.contains('[WARNING] No signature for test:project-jar:pom:0.0.1')
+
+assert buildLog.contains('[INFO] BUILD SUCCESS')

src/it/reactorProcessJar/project-verifier/pom-test.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
   ~ Copyright 2018 Wren Security
+  ~ Copyright 2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -43,7 +44,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifyReactorDependencies>true</verifyReactorDependencies>
                 </configuration>
                 <executions>

src/it/reactorProcessPom/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('[ERROR] No signature for test:project-pom:pom:0.0.1')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[WARNING] No signature for test:project-pom:pom:0.0.1')
+assert buildLog.contains('[INFO] BUILD SUCCESS')

src/it/reactorProcessPom/project-verifier/pom-test.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
   ~ Copyright 2018 Wren Security
+  ~ Copyright 2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -44,7 +45,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifyReactorDependencies>true</verifyReactorDependencies>
                 </configuration>
                 <executions>

src/it/reactorProcessTestJar/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,9 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('[ERROR] No signature for test:project-test-jar:test-jar:tests:0.0.1')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[WARNING] No signature for test:project-test-jar:test-jar:tests:0.0.1')
+assert buildLog.contains('[WARNING] No signature for test:project-test-jar:pom:0.0.1')
+
+assert buildLog.contains('[INFO] BUILD SUCCESS')

src/it/reactorProcessTestJar/project-verifier/pom-test.xml

@@ -1,6 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
   ~ Copyright 2018 Wren Security
+  ~ Copyright 2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -44,7 +45,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifyReactorDependencies>true</verifyReactorDependencies>
                 </configuration>
                 <executions>

src/it/snapshotProcess/pom-test.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-  ~ Copyright 2015 Slawomir Jaranowski
+  ~ Copyright 2015-2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -61,7 +61,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifySnapshots>true</verifySnapshots>
                 </configuration>
                 <executions>

src/it/snapshotProcess/postbuild.groovy

@@ -1,5 +1,5 @@
 /*
- * Copyright 2019 Slawomir Jaranowski
+ * Copyright 2019-2021 Slawomir Jaranowski
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -13,7 +13,7 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-def buildLog = new File( basedir, 'build.log' )
+def buildLog = new File( basedir, 'build.log' ).text
 
-assert buildLog.text.contains('[ERROR] No signature for org.apache.maven:maven-parent:pom:32-SNAPSHOT')
-assert buildLog.text.contains('[INFO] BUILD FAILURE')
+assert buildLog.contains('[WARNING] No signature for org.apache.maven:maven-parent:pom:32-SNAPSHOT')
+assert buildLog.contains('[INFO] BUILD SUCCESS')

src/it/systemProcess/pom-test.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!--
-  ~ Copyright 2015 Slawomir Jaranowski
+  ~ Copyright 2015-2021 Slawomir Jaranowski
   ~
   ~ Licensed under the Apache License, Version 2.0 (the "License");
   ~ you may not use this file except in compliance with the License.
@@ -48,7 +48,6 @@
                 <artifactId>pgpverify-maven-plugin</artifactId>
                 <version>@project.version@</version>
                 <configuration>
-                    <failNoSignature>true</failNoSignature>
                     <verifySystemDependencies>true</verifySystemDependencies>
                 </configuration>
                 <executions>