Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store key not found in cache #313

Closed
slawekjaranowski opened this issue Aug 21, 2021 · 5 comments · Fixed by #336
Closed

Store key not found in cache #313

slawekjaranowski opened this issue Aug 21, 2021 · 5 comments · Fixed by #336
Assignees
@slawekjaranowski
Labels
enhancement New feature or request. todo Assigned and will be done.

Comments

@slawekjaranowski
Copy link
Member

When key is not published to public key servers we don't need look up for key every time verification is run.

We can store this information in cache and (re-try after cache invalidated).

Continuation for: #305

May impact on: #284
@slawekjaranowski slawekjaranowski added the enhancement New feature or request. label Aug 21, 2021
@protocol7
Copy link

Just checking in on the progress on this feature. We're looking at using pgpverify-maven-plugin for a project with a very large number of dependencies, and since this contains a number of dependencies without keys, this is currently slowing down the build quite significantly.

My experience with Maven plugins is limited, so not sure to what extent I would be able to help with a patch. But if there's anything I can do to support, I'm happy to do so.

@slawekjaranowski
Copy link
Member Author

Thanks for interesting .... I will try to fix it ... Anyway any help in this is appreciated

@slawekjaranowski slawekjaranowski added the todo Assigned and will be done. label Nov 9, 2021
@protocol7
Copy link

protocol7 commented Nov 9, 2021 •
edited
Loading

Thanks! I can certainly offer to review any PR and try it out on our use case.

@slawekjaranowski slawekjaranowski self-assigned this Nov 10, 2021
slawekjaranowski added a commit that referenced this issue Nov 11, 2021
@slawekjaranowski
Store key not found result in cache
b9eccfa 
Fix: #313
slawekjaranowski added a commit that referenced this issue Nov 11, 2021
@slawekjaranowski
Store key not found result in cache
856367d 
Fix #313
@slawekjaranowski slawekjaranowski mentioned this issue Nov 11, 2021
Merged
slawekjaranowski added a commit that referenced this issue Nov 11, 2021
@slawekjaranowski
Store key not found result in cache
b5b929e 
Fix #313
@slawekjaranowski
Copy link
Member Author

@protocol7 - PR ready - waiting for your review

@protocol7
Copy link

Thanks, tested. Found a bug which I've made a suggestion to fix in the PR, but with that fix in place it works as expected for our case.

slawekjaranowski added a commit that referenced this issue Nov 11, 2021
@slawekjaranowski
Store key not found result in cache
2fef574 
Fix #313
slawekjaranowski added a commit that referenced this issue Nov 12, 2021
@slawekjaranowski
Store key not found result in cache
c843271 
Fix #313
pzygielo pushed a commit to pzygielo/pgpverify-maven-plugin that referenced this issue May 31, 2024
@cstamas
[MRESOLVER-380] Failed attempts are not removed (s4u#313)
0d7cb6e 
And logged thread diag does not distinguish: "waits for X" or "has X".

---

https://issues.apache.org/jira/browse/MRESOLVER-380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slawekjaranowski slawekjaranowski

Labels
enhancement New feature or request. todo Assigned and will be done.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Store key not found result in cache s4u/pgpverify-maven-plugin
2 participants
@protocol7 @slawekjaranowski