Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect reading of the file with artifact key identifiers #499

Closed
freedom1b2830 opened this issue Nov 26, 2023 · 1 comment · Fixed by #534
Closed

Incorrect reading of the file with artifact key identifiers #499

freedom1b2830 opened this issue Nov 26, 2023 · 1 comment · Fixed by #534
Assignees
Labels
bug Something isn't working.

Comments

@freedom1b2830
Copy link

Describe the bug
The plugin ignores the noSig instruction for the artifact, possibly due to the use of capital letters in the version.

To Reproduce

<repository>
	<id>papermc</id>
	<url>https://repo.papermc.io/repository/maven-public/</url>
</repository>
<dependency>
	<groupId>io.papermc.paper</groupId>
	<artifactId>paper-api</artifactId>
	<version>1.20.1-R0.1-SNAPSHOT</version>
	<scope>provided</scope>
</dependency>

pgp map key file:

io.papermc.paper:paper-api:jar:1.20.1-R0.1-SNAPSHOT = noSig
io.papermc.paper:paper-api:pom:1.20.1-R0.1-SNAPSHOT = noSig

see log
[ERROR] Unsigned artifact not listed in keys map: io.papermc.paper:paper-api:jar:1.20.1-R0.1-SNAPSHOT
[ERROR] Unsigned artifact not listed in keys map: io.papermc.paper:paper-api:pom:1.20.1-R0.1-SNAPSHOT

Expected behavior
plugin version, goal
pgpverify-maven-plugin:1.17.0:check

@slawekjaranowski slawekjaranowski added the bug Something isn't working. label Apr 10, 2024
@slawekjaranowski slawekjaranowski self-assigned this Apr 10, 2024
slawekjaranowski added a commit that referenced this issue Apr 11, 2024
Use BaseVersion for artifacts version checking - fix #499
@slawekjaranowski
Copy link
Member

@freedom1b2830 - thanks for reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Development

Successfully merging a pull request may close this issue.

2 participants