Show, fix and start failing on compiler warnings. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Please review current sonar rules
https://sonarcloud.io/organizations/simplify4u/quality_profiles/show?language=java&name=Simplify4U+way
slawekjaranowski
approved these changes
Jun 5, 2020
Have a look at my proposal: It should be comparing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Not for release 1.8.0.)
Start showing compiler warnings and fail on these warnings. In my experience any compiler warning is a valid concern to be fixed so why not report them during maven builds and fail on these warnings.