Extract load PGPSignature utility. Fix close. #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract a utility method for loading PGPSignature content and add some unit tests for this. Make loading logic more robust to bad content. It seems that in the original code, the constructed FileInputStream is never closed. This could explain the flaky Windows build agent failures.
cobratbq
force-pushed
the
extract-utility-pgpsignature-loading
branch
from
2f5ab4b to
3230cfe
Compare
|
SonarCloud Quality Gate failed.
|
slawekjaranowski
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract a utility method for loading PGPSignature content and add some
unit tests for this. Make loading logic more robust to bad content.
It seems that in the original code, the constructed FileInputStream is
never closed. This could explain the flaky Windows build agent failures.