- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking for weak signatures #18
Merged
+31
−2
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended that SHA-224 is considered weak but not SHA-1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, although I know it's weird. My reasoning is that SHA-1 is so commonly used that marking it as weak at this point would flood developers with warning/error messages, even though it's strictly weaker than SHA-224. Essentially the same reasoning used by the developer of OpenKeychain when they built their list of allowed signature algorithms.
I originally checked the security of the underlying public key as well, but the same problem occurred (so, so many RSA keys under 2048 bits...). One of the chief advantages of this plugin (IMO) is its SSH-like security model - as a rule, it won't spam warnings at you unless something is seriously wrong and it won't fail the build unless you're probably under attack (at least under default settings), so I'm hesitant to add a whole bunch of error messages for common cases that developers can't do anything about.
That being said, if we judge that SHA224 is still an improvement over SHA1 (which it is by bits of security, if not frequency of use) then I can remove it from this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks. Just noticed it and thought it looked strange but now I know it is a reason behind it.