Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use new feature of maven-invoker-plugin 3.2.2 #244

Merged
merged 1 commit into from
Mar 6, 2021
Merged

use new feature of maven-invoker-plugin 3.2.2 #244

merged 1 commit into from
Mar 6, 2021

Conversation

slawekjaranowski
Copy link
Member

No description provided.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@slawekjaranowski slawekjaranowski merged commit 51ab89b into master Mar 6, 2021
@slawekjaranowski slawekjaranowski deleted the new-invoker branch March 6, 2021 09:29
@slawekjaranowski slawekjaranowski added the code quality Improvements, refactor or code cleanup. label Mar 6, 2021
pzygielo pushed a commit to pzygielo/pgpverify-maven-plugin that referenced this pull request May 31, 2024
@cstamas
[MRESOLVER-316] DF Collector may enter endless loop (s4u#244)
88dab9f 
When resolving artifact from issue, the DF collector enters endless loop. But the loop is NOT in collecting, it happens when DF detect unsolvable problem, and tries to report it. To report it, it needs to visit the graph of collected nodes, but that graph contains loops (and it is expected).

But, the problem is that PathRecordingDependencyVisitor used to collect paths chokes on loops.

Fix: just like in RepositorySystem#resolveDependencies, wrap up the graph visitor into TreeDependencyVisitor, that creates tree-like (loopless, tree by def) "view" of graph.

With this fix, DF immediately detects that artifact in issue is unresolvable (just like BF does), as it contains unsolvable (not intersecting) ranges.

---

https://issues.apache.org/jira/browse/MRESOLVER-316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code quality Improvements, refactor or code cleanup.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@slawekjaranowski