Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamped snapshot version to example regular expressions #348

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

ao-apps
Copy link
Contributor

@ao-apps ao-apps commented Dec 6, 2021

*-SNAPSHOT versions can also be matched against their timestamped representation,
such as *-20211206.032231-24 We have modified the example snapshot regular
expression to match either form of snapshot version.

This builds on #347, if you would like a rebase once #347 is merged, bounce this back to us.

@ao-apps ao-apps marked this pull request as draft December 6, 2021 03:47
@ao-apps ao-apps force-pushed the timestamped-snapshots branch from 601e370 to 24ca272 Compare December 6, 2021 03:52
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 03:53
@ao-apps ao-apps marked this pull request as draft December 6, 2021 04:14
@ao-apps ao-apps force-pushed the timestamped-snapshots branch from 24ca272 to 12fbccb Compare December 6, 2021 04:25
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 04:26
@ao-apps ao-apps marked this pull request as draft December 6, 2021 05:10
@ao-apps ao-apps force-pushed the timestamped-snapshots branch from 12fbccb to 301e3c7 Compare December 6, 2021 05:25
@ao-apps ao-apps marked this pull request as ready for review December 6, 2021 05:26
@ao-apps
Copy link
Contributor Author

ao-apps commented Dec 6, 2021

We've finished our changes to this PR. Unless our C.I. builds catch any issues (clear so far), this should be good-to-go.

Thanks,

  • Dan

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebeas

`*-SNAPSHOT` versions can also be matched against their timestamped representation,
such as `*-20211206.032231-24`  We have modified the example snapshot regular
expression to match either form of snapshot version.
@ao-apps ao-apps force-pushed the timestamped-snapshots branch from 301e3c7 to 934cacd Compare December 16, 2021 16:54
@ao-apps
Copy link
Contributor Author

ao-apps commented Dec 16, 2021

Done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@slawekjaranowski slawekjaranowski added the documentation Improvements or additions to documentation. label Dec 16, 2021
@slawekjaranowski slawekjaranowski merged commit eab7f52 into s4u:master Dec 16, 2021
@ao-apps ao-apps deleted the timestamped-snapshots branch December 16, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation.
Development

Successfully merging this pull request may close these issues.

2 participants