Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warning for missing keysmap. #99

Merged
merged 1 commit into from
May 13, 2020

Conversation

cobratbq
Copy link
Contributor

Emit a warning explaining the limitation of validation when a reference of trust is missing.

This should help to inform users of the limitations that exist when using this plugin if no source of trust is specified.

Please, feel free to suggest a better warning message. This message is a bit verbose.

@cobratbq cobratbq force-pushed the warning-on-missing-keysmap branch from ad2608f to 41469c2 Compare May 10, 2020 15:56
@slawekjaranowski slawekjaranowski self-requested a review May 13, 2020 14:33
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to minimize lines of code for this class and delegate responsibility to place where action is taken.
Please add this message to KeysMap class.
In KeysMap class after parse file we can check if any keys definition are added.

@cobratbq cobratbq force-pushed the warning-on-missing-keysmap branch from 41469c2 to 424577f Compare May 13, 2020 15:23
@slawekjaranowski
Copy link
Member

ok, and please rebase the latest changes from master.

@cobratbq cobratbq force-pushed the warning-on-missing-keysmap branch from 424577f to a10bf8b Compare May 13, 2020 16:18
Emit a warning explaining the limitation of validation when a reference
of trust is missing.
@cobratbq cobratbq force-pushed the warning-on-missing-keysmap branch from a10bf8b to b65a923 Compare May 13, 2020 16:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cobratbq cobratbq requested a review from slawekjaranowski May 13, 2020 16:28
@slawekjaranowski slawekjaranowski merged commit 262e33f into s4u:master May 13, 2020
@slawekjaranowski slawekjaranowski added this to the v1.8.0 milestone May 13, 2020
@cobratbq cobratbq deleted the warning-on-missing-keysmap branch May 13, 2020 17:03
pzygielo pushed a commit to pzygielo/pgpverify-maven-plugin that referenced this pull request May 31, 2024
Demo snippets did run all "demos" but using SL only,
now it runs with SL, guice, sisu.

This closes s4u#99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants