Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The search input is disabled when allowNewOption is set to true and the options are empty. #313

Closed
funnygod opened this issue Mar 6, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@funnygod
Copy link

funnygod commented Mar 6, 2024

When I try to use allowNewOption with an empty option, it also causes the search input to be disabled. Could you please enable the search input when allowNewOption is true? it worked perfectly before version 1.0.41
image

@gnbm
Copy link
Collaborator

gnbm commented Mar 6, 2024

@funnygod Can include a working example for your scenario?.
I might also be missing something but I'm not being able to replicate what you mentioned, so an example with your configs and steps to reproduce would be great, as well as clarify what you mean by empty option?

@funnygod
Copy link
Author

funnygod commented Mar 6, 2024

@funnygod Can include a working example for your scenario?. I might also be missing something but I'm not being able to replicate what you mentioned, so an example with your configs and steps to reproduce would be great, as well as clarify what you mean by empty option?

Hi @gnbm
Here is the example of 1.0.40 that working
https://codepen.io/lim-chong-hooi/pen/vYMNyRN

Here is a example of version 1.0.41 where the search input has been disabled.
https://codepen.io/lim-chong-hooi/pen/OJGybam

@gnbm gnbm added the bug Something isn't working label Mar 6, 2024
@gnbm
Copy link
Collaborator

gnbm commented Mar 7, 2024

@funnygod Can include a working example for your scenario?. I might also be missing something but I'm not being able to replicate what you mentioned, so an example with your configs and steps to reproduce would be great, as well as clarify what you mean by empty option?

Hi @gnbm Here is the example of 1.0.40 that working https://codepen.io/lim-chong-hooi/pen/vYMNyRN

Here is a example of version 1.0.41 where the search input has been disabled. https://codepen.io/lim-chong-hooi/pen/OJGybam

@funnygod In a couple of days I'll try to create a PR with a fix for this since I was already able to figure out what's the problem

@gnbm
Copy link
Collaborator

gnbm commented Mar 7, 2024

@funnygod Opened a PR that includes a fix for this.
Can you please review it while I wait for @sa-si-dev validation?

gnbm added a commit that referenced this issue Mar 8, 2024
@funnygod
Copy link
Author

@funnygod Opened a PR that includes a fix for this. Can you please review it while I wait for @sa-si-dev validation?

@gnbm I've tested it, and it's working well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants