Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with mark replacing html tags #250

Merged
merged 3 commits into from
May 29, 2023
Merged

Conversation

neonrust
Copy link
Contributor

@neonrust neonrust commented May 5, 2023

Or at least, made it far less probable.

Tweak found on Stack Overflow.

Fixes issue #249

Or at least, made it far less probable.
@neonrust
Copy link
Contributor Author

neonrust commented May 8, 2023

In principle, I agree, but I don't think that's even measurable in this case.
Also, I wanted to keep the change as small as possible.

@sa-si-dev
Copy link
Owner

Thanks @neonrust and @gnbm for your contribution.

I will check and merge this change in the next release.

@gnbm gnbm self-requested a review May 21, 2023 20:28
src/virtual-select.js Show resolved Hide resolved
@gnbm
Copy link
Collaborator

gnbm commented May 26, 2023

@neonrust I would like to close a release until Monday, would it be possible to take a look at the PR feedback, please? Thank you

@gnbm gnbm self-requested a review May 29, 2023 14:20
src/virtual-select.js Show resolved Hide resolved
@gnbm gnbm merged commit e5adfd9 into sa-si-dev:master May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants