Guarantee that the select is focus after the component is closed; #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnbm
changed the title
|
@JoaoFerreira-FrontEnd Can you please add the test scenarios? Thanks |
|
Thanks @JoaoFerreira-FrontEnd for your contribution. |
gnbm
approved these changes
May 29, 2023
|
To test the use case you just need to choose an item on a single select, and on after close click enter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to improve the user experience of the select when we are not using the mouse.
What was happening?
After selecting a dropdown item, the focus seems to go to the body, instead of returning to the dropdown trigger.
What was done?
Set the input on focus when the dropdown was closed.