Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dropdown Search/Tags accessibility issues #350

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Aug 22, 2024

  • Guarantee that the component's focus occurs when the dropdown is closed.

What was happening

  1. When the dropdown was closed via ESC the focus was lost to the body;
  2. When we navigate with the TAB key throughout the dropdown sometimes it doesn't close, and other times the focus is lost to the body.

After the fix

  • Every time we close the dropdown via TAB or ESC key the dropdown is focused.
  • Followed the same steps above - ✅
  • Ran regression scenarios - ✅
  • Run automated tests - ✅

image

@gnbm gnbm requested review from gnbm and sa-si-dev August 22, 2024 11:53
Copy link
Collaborator

@gnbm gnbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gnbm gnbm merged commit 80cab74 into sa-si-dev:master Aug 22, 2024
@gnbm gnbm mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants