Fix XSS vulnerability in VirtualSelect #366
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sa-si-dev#365 Update the `secureText` method in `src/virtual-select.js` to enhance XSS protection. * Modify the return statement to use `Utils.replaceDoubleQuotesWithHTML(this.$secureDiv.innerHTML)` instead of `this.$secureDiv.innerHTML`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/sa-si-dev/virtual-select/issues/365?shareId=XXXX-XXXX-XXXX-XXXX).
|
@izambasiron please create some automated test scenarios to make sure the change will not break any use case as well as make it more future proof |
|
@izambasiron Since I wanted to fix and update some smaller things before doing a new release I decided to include this with a slight difference if you want to check it here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #365
Update the
secureTextmethod insrc/virtual-select.jsto enhance XSS protection.Utils.replaceDoubleQuotesWithHTML(this.$secureDiv.innerHTML)instead ofthis.$secureDiv.innerHTML.For more details, open the Copilot Workspace session.