Updates computing_technology.h based on #284 proposal #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craddm
reviewed
Oct 11, 2023
| - You must ensure that all projects understand what resources are available and what the associated costs will be before the project starts. | ||
| - For on-premises systems this might be related to the available hardware, for cloud-based systems there might be limits on how many instances of a particular resource (_e.g._ GPUs) can be used | ||
| - You must ensure that all project members understand what resources are available and what the associated costs will be before the project starts. | ||
| - For on-premises systems this might be related to the available hardware, for cloud-based systems there might be limits on how many instances of a particular resource (_e.g._ GPUs) can be used. |
There was a problem hiding this comment.
Suggested change
| - For on-premises systems this might be related to the available hardware, for cloud-based systems there might be limits on how many instances of a particular resource (_e.g._ GPUs) can be used. | |
| - For on-premises systems this might be related to the available hardware. For cloud-based systems there might be limits on how many instances of a particular resource (_e.g._ GPUs) can be used. |
|
I think this is good to get in, but since it modifies some statements I don't think we can review this in time for 1.0.0. We should attempt to get this into the first post-1.0.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
☑️ Maintainers' checklist
Per proposal in #284
🌂 Related issues
Relates to #284
🙋 Acknowledging contributors