Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: split out main.go functionality #188

Merged
merged 5 commits into from
Aug 20, 2023
Merged

refactor: split out main.go functionality #188

merged 5 commits into from
Aug 20, 2023

Conversation

sa7mon
Copy link
Owner

@sa7mon sa7mon commented Aug 20, 2023 •
edited
Loading

  • move and rename main() to new cmd
  • make new module: worker
  • move arg methods to new file
  • add tests for validating config

Future changes:

Closes #141

@sa7mon sa7mon added the refactor Code cleanup / optimization label Aug 20, 2023
@sa7mon sa7mon linked an issue Aug 20, 2023 that may be closed by this pull request
Move main.go functionality to cmd #141
Closed
@github-actions
Copy link

Code Coverage

Package Line Rate Complexity Health
github.com/sa7mon/s3scanner/bucket 90% 0 ✔
github.com/sa7mon/s3scanner/cmd/s3scanner 19% 0 ❌
github.com/sa7mon/s3scanner/db 73% 0 ➖
github.com/sa7mon/s3scanner/permission 77% 0 ✔
github.com/sa7mon/s3scanner/provider 81% 0 ✔
github.com/sa7mon/s3scanner/worker 49% 0 ❌
Summary 65% (496 / 758) 0 ➖

@sa7mon sa7mon merged commit f89b4f5 into main Aug 20, 2023
@sa7mon sa7mon deleted the 141 branch August 20, 2023 21:37
@chenrui333 chenrui333 mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactor Code cleanup / optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move main.go functionality to cmd
1 participant
@sa7mon