bug: use credentials when scanning #337
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
As reported in #328, credentials stored in
~/.aws/credentials
or a path located by theAWS_SHARED_CREDENTIALS_FILE
environment variable were not being used when scanning buckets. Because of this, any results from scanning AWS buckets would be potentially missingAUTH_USERS
permissions.This was an unfortunate oversight when re-writing S3Scanner in Go mostly due to the account ownership of the test buckets not being fully understood at that time. Consequently, the unit tests to verify this functionality did not report accurately.
Changes
READ
andREAD_ACL
operations on certain test buckets).ParseAclOutputv2
AWS_PROFILE
environment variable.-verbose
is suppliedCloses #328