Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown and Tooltip missing one direction #1218

Closed
brunocalou opened this issue Oct 7, 2022 · 1 comment
Closed

Dropdown and Tooltip missing one direction #1218

brunocalou opened this issue Oct 7, 2022 · 1 comment

Comments

@brunocalou
Copy link
Contributor

Hello guys, I have a use case that is not possible to achieve right now.

The dropdown component has top, left, and right directions. The bottom is the default one. It works for most use cases but fails when I need the dropdown to appear on top on mobile and bottom on desktop. That's because once I add dropdown-top, there is no class to override the top style, like lg:dropdown-bottom. According to the tailwind docs, there is no way to target a single breakpoint.

The same happens with the Tooltip, but the top direction is missing.

If it makes sense, I can open a PR with the change.
@NikarashiHatsu
Copy link
Contributor

I just noticed that dropdown-bottom modifier is missing.
It would really helpful to have such modifier.

inorganik pushed a commit to inorganik/daisyui that referenced this issue Feb 7, 2023
@brunocalou
fix: saadeghi#1218 - Add missing modifiers on dropdown and tooltip (s…
1f66be4 
…aadeghi#1232)

* feat: add dropdown-bottom modifier

* feat: add tooltip-top modifier

* fix: dropdown styles
imgbot bot pushed a commit to Avensen/daisyui that referenced this issue Jun 5, 2023
@brunocalou @ImgBotApp
fix: saadeghi#1218 - Add missing modifiers on dropdown and tooltip (s…
ac08bbb 
…aadeghi#1232)

* feat: add dropdown-bottom modifier

* feat: add tooltip-top modifier

* fix: dropdown styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brunocalou @NikarashiHatsu