Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1218 - Add missing modifiers on dropdown and tooltip #1232

Merged
merged 3 commits into from
Oct 29, 2022

Conversation

brunocalou
Copy link
Contributor

This PR adds the dropdown-bottom and tooltip-top modifiers. They are needed for the following use case:

  • Show dropdown on top on mobile and on bottom on desktop. It's impossible without the dropdown-bottom modifier, since the dropdown-top would be applied for all screen sizes and there would be no class to override it. e.g.
<div class="dropdown dropdown-top lg:dropdown-bottom">

The same use case applies to the tooltip, but the bottom and top are inverted. e.g.

<div class="tooltip tooltip-bottom lg:tooltip-top">

Video

Gravacao.de.Tela.2022-10-10.as.16.10.35.mov

@brunocalou brunocalou changed the title fix #1218 - Add missing modifiers on dropdown and tooltip fix: #1218 - Add missing modifiers on dropdown and tooltip Oct 10, 2022
@saadeghi
Copy link
Owner

Thank you 🙌
I will check the changes today and I will merge it if everything's okay.

@saadeghi saadeghi merged commit 1728632 into saadeghi:master Oct 29, 2022
inorganik pushed a commit to inorganik/daisyui that referenced this pull request Feb 7, 2023
…aadeghi#1232)

* feat: add dropdown-bottom modifier

* feat: add tooltip-top modifier

* fix: dropdown styles
imgbot bot pushed a commit to Avensen/daisyui that referenced this pull request Jun 5, 2023
…aadeghi#1232)

* feat: add dropdown-bottom modifier

* feat: add tooltip-top modifier

* fix: dropdown styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants