Fix typos in README #236
Merged
Fix typos in README #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). |
naveen521kk
requested changes
Aug 28, 2020
README.md
Outdated
| @@ -99,9 +99,9 @@ Note: Instead of creating a .env file, you can just run this command "cp env.exa | |||
| REACT_APP_GITHUB_TOKEN = "YOUR GITHUB TOKEN HERE" | |||
| ``` | |||
|
|
|||
| Set `showGithubProfile` to true or false to show Contact Profile using Github, defaults to false. | |||
| Set `showGithubProfile` to true or false to show Contact Profile using Github,Default is set as false. | |||
There was a problem hiding this comment.
I think the previous one correct.
There was a problem hiding this comment.
@lARSHADl Could you revert this to how it was before?
naveen521kk
requested changes
Aug 29, 2020
README.md
Outdated
|
|
||
| Note: Open Source Projects section only show pinned itens of your Github. If you are seeing [this](https://i.imgur.com/Hj6mu1K.png), please follow this | ||
| Note: Open Source Projects section only show pinned items of your Github. If you are seeing [this](https://i.imgur.com/Hj6mu1K.png), please follow this |
There was a problem hiding this comment.
Suggestion: Embed the image instead of saying, if you see this.
kartikcho
requested changes
Aug 30, 2020
README.md
Outdated
|
|
||
| Note: Open Source Projects section only show pinned itens of your Github. If you are seeing [this](https://i.imgur.com/Hj6mu1K.png), please follow this | ||
| Note: Open Source Projects section only show pinned items of your Github. If you are seeing [this](https://i.imgur.com/Hj6mu1K.png), please follow this |
There was a problem hiding this comment.
Change follow this to follow these.
README.md
Outdated
|
|
||
| Note: Open Source Projects section only show pinned itens of your Github. If you are seeing [this](https://i.imgur.com/Hj6mu1K.png), please follow this | ||
| Note: Open Source Projects section only show pinned items of your Github. If you are seeing [this](https://i.imgur.com/Hj6mu1K.png), please follow this | ||
| [Instructions](https://docs.github.com/en/enterprise/2.13/user/articles/pinning-items-to-your-profile). |
There was a problem hiding this comment.
Remove capitalized I in Instructions.
|
Any update on this @lARSHADl ? |
|
Sorry guys new to github and this was my first commit |
|
Done !
…-------- Original Message --------
On Sep 7, 2020, 8:18 PM, Naveen M K wrote:
@naveen521kk commented on this pull request.
---------------------------------------------------------------
In [README.md](#236 (comment)):
> @@ -99,9 +99,9 @@ Note: Instead of creating a .env file, you can just run this command "cp env.exa
REACT_APP_GITHUB_TOKEN = "YOUR GITHUB TOKEN HERE"
```
-Set `showGithubProfile` to true or false to show Contact Profile using Github, defaults to false.
+Set `showGithubProfile` to true or false to show Contact Profile using Github,Default is set as false.
***@***.***(https://github.com/lARSHADl) Could you revert this to how it was before?
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#236 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AK3533HVPHJYULGNW2V7KCLSETXDXANCNFSM4QMP5PBQ).
|
naveen521kk
reviewed
Sep 7, 2020
README.md
Outdated
Comment on lines
105
to
108
|
|
||
|
|
||
| <img src = "https://i.imgur.com/Hj6mu1K.png" alt = " Error" > | ||
|
|
There was a problem hiding this comment.
Why not use markdown like
Suggested change
| <img src = "https://i.imgur.com/Hj6mu1K.png" alt = " Error" > | |
|  |
naveen521kk
reviewed
Sep 7, 2020
README.md
Outdated
|
|
||
| <img src = "https://i.imgur.com/Hj6mu1K.png" alt = " Error" > | ||
|
|
||
| Please follow these | ||
| [Instructions](https://docs.github.com/en/enterprise/2.13/user/articles/pinning-items-to-your-profile). |
There was a problem hiding this comment.
As @kartikcho said do
Suggested change
| [Instructions](https://docs.github.com/en/enterprise/2.13/user/articles/pinning-items-to-your-profile). | |
| [instructions](https://docs.github.com/en/enterprise/2.13/user/articles/pinning-items-to-your-profile). |
|
Will change to the last check point with ! Markdown . |
|
Is there anything that's bothering you, please feel free to suggest ? |
naveen521kk
approved these changes
Sep 10, 2020
|
@all-contributors please add @lARSHADl for doc |
|
I've put up a pull request to add @lARSHADl! 🎉 |
Mehranmzn
pushed a commit
to Mehranmzn/mehranmzn.github.io
that referenced
this pull request
Sep 13, 2024
* Update README.md * Correction * Image added * Added space * Image added * Update Readme * Update READ.md * new * Fix typos in READ.md * Change some lingo Co-authored-by: Kartik Choudhary <kartikch918@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.